fix: The image should only be built when explicitly released, or when triggered manually #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… triggered manually
xffxff
reviewed
Jan 16, 2024
There was a problem hiding this comment.
@soulteary Thank you for your contribution to the project. You are absolutely right in identifying that the current setup triggers an image build with every modification, which isn't always necessary.
However, I believe a further discussion might be needed. Left some comments
findmyway
approved these changes
Jan 17, 2024
xffxff
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, every modification to the project will trigger the image build, but in fact it should only trigger the build when a new version is released, or manually trigger the CI build in the background.
Hope it helps.