Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql subject : is external libraries allowed (for svg graphs) #2312

Closed
fulverin opened this issue Nov 26, 2023 · 2 comments · Fixed by #2317
Closed

graphql subject : is external libraries allowed (for svg graphs) #2312

fulverin opened this issue Nov 26, 2023 · 2 comments · Fixed by #2317
Assignees

Comments

@fulverin
Copy link

fulverin commented Nov 26, 2023

graphql

Hi,
I audited a lot of grahql that used external libraries to display data as graph.
Seems like most people assume that is OK; it wasn't my understanding.
I suggest to make an explicit statement in the instructions/audit.

@fulverin
Copy link
Author

fulverin commented Nov 26, 2023

but if it is ok and it is only me misunderstanding instructions, then never mind.

This graphs must be done using [SVG].

but the above phrase makes me think it should be done from scratch.

@MSilva95 MSilva95 self-assigned this Nov 27, 2023
@MSilva95 MSilva95 linked a pull request Nov 27, 2023 that will close this issue
@MSilva95
Copy link
Member

Hello @fulverin thank you for the feedback and the attention to detail, I've reshaped the questions in the audit and and improved the language as well, now we ask for the usage of "svg" in the audit as we ask in the readme instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants