-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md for atm management audit #1003
Conversation
|
||
###### Are you able to withdraw money? | ||
|
||
###### And if so, was the withdraw updated in the file `"records.txt"`? | ||
|
||
###### Is it not possible to withdraw an amount superior to your available balance? | ||
###### Is it possible to withdraw an amount superior to your available balance? | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you remove the "not" it will change the sentence.
in order to pass the questions the answer for it should be always "yes", otherwise it will fail the audit.
and if you say yes to this question you are saying that it is possible to withdraw an amount superior to your available balance which should not be possible!
We can do it like this:
Can you confirm that it is not possible to withdraw more than your available balance?
Now if you say yes it is correct and it will pass the audit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should maybe change the sentence to: Does the system forbid to withdraw an amount superior to your available balance
?
|
||
##### Resorting to the user Alice, try and select the option `"Update information of account"` and select one of the accounts you created for Alice. | ||
##### Referring to the user Alice, select the option `"Update account information"` and select one of the accounts you created for Alice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Referring" is not the best option i think "Using" is better
Because resorting and using is basically the same thing but referring is different
This applies to the rest of the audit
|
||
###### Can you confirm that those account were deleted, both in the application and file `"records.txt"`? | ||
|
||
##### Resorting to the user Alice select the option `"Remove existing account"` and try to remove and nonexisting account. | ||
##### Referring to the user Alice select the option `"Remove existing account"` and try to remove a account that doesn't exist. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we try to avoid using the apostrophe to make the English simple and easy for every one, because not all the students have good English. So, you need to avoid using (don't, doesn't, ...) and instead use (do not, does not, ...)
Using the user Alice select the option "Remove existing account"
and try to remove an account that does not exist.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not it be remove **an** account that does not exist
( no contractions)
|
||
###### +Did the student update the terminal interface? | ||
|
||
###### +Is the password saved in the file `"users.txt"` encrypted? | ||
|
||
###### +Did the student create a relational database? • 6 | ||
###### +Did the student create a relational database? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "• 6" must not be removed.
It is part of the structure of the audit, it is a way to give weight to the bonus questions so that we can give more or less XP points
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments for you to change some stuff, because some things may not be changed.
You have to be careful not to change the sentence of the questions in the audits
solved in #2195 |
No description provided.