Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Con 1756 markdown let s play java project #2093

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Con 1756 markdown let s play java project #2093

merged 3 commits into from
Jul 31, 2023

Conversation

zanninso
Copy link
Contributor

Before starting, please choose the relevant pull request Labels, Reviewers, and Assignees

Why?

Clearly state the reason for this change. What problem is it solving or feature is it adding?

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub compliant mermaid graphs to visually represent the solution.

Implementation Details

Explain the details of the implementation and the reasoning behind it. What alternative approaches were considered and why was this approach chosen?

@zanninso zanninso requested a review from akhossanX July 20, 2023 14:44
akhossanX
akhossanX suggested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@akhossanX akhossanX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix some typos

@zanninso zanninso requested a review from akhossanX July 27, 2023 15:49
akhossanX
akhossanX approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@akhossanX akhossanX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

@zanninso zanninso merged commit 1ea8c5a into master Jul 31, 2023
2 checks passed
@zanninso zanninso deleted the CON-1756-MARKDOWN-Let-s-Play-Java-Project branch July 31, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhossanX akhossanX akhossanX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanninso @akhossanX