Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-1813-MARKDOWN-chaikin-raid-for-java-piscine #2104

Merged
merged 4 commits into from
Aug 28, 2023
Merged

CON-1813-MARKDOWN-chaikin-raid-for-java-piscine #2104

merged 4 commits into from
Aug 28, 2023

Conversation

zainabdnaya
Copy link
Contributor

Before starting, please choose the relevant pull request Labels, Reviewers, and Assignees

Why?

Clearly state the reason for this change. What problem is it solving or feature is it adding?

Solution Overview

Provide an overview of the solution implemented in this pull request. This should be a high level overview without getting into technical details. If applicable, include screenshots of UI or use GitHub compliant mermaid graphs to visually represent the solution.

Implementation Details

Explain the details of the implementation and the reasoning behind it. What alternative approaches were considered and why was this approach chosen?

@zanninso zanninso self-requested a review August 5, 2023 00:35
zanninso
zanninso requested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left one comment to resolve

subjects/java/piscine/raids/Jaikin/audit/README.md Outdated Show resolved Hide resolved
@zanninso zanninso merged commit f8031ae into master Aug 28, 2023
2 checks passed
@zanninso zanninso deleted the CON-1813-MARKDOWN-chaikin-raid-for-java-piscine branch August 28, 2023 15:56
zanninso added a commit that referenced this pull request Sep 8, 2023
@zanninso
Revert "CON-1813-MARKDOWN-chaikin-raid-for-java-piscine (#2104)"
aec5c3c 
This reverts commit f8031ae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanninso zanninso zanninso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zainabdnaya @zanninso