Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-1774-MARKDOWN-Nexus-Java-Project #2117

Merged
merged 15 commits into from
Sep 19, 2023
Merged

CON-1774-MARKDOWN-Nexus-Java-Project #2117

merged 15 commits into from
Sep 19, 2023

Conversation

akhossanX
Copy link
Contributor

I made 2 sample examples for the project,
Please Review the markdowns and base on your feedback we'll discuss and decide which one of the 2 samples
aligns with the intended pedagogical goals.

@akhossanX akhossanX requested a review from zanninso August 7, 2023 11:46
@akhossanX akhossanX self-assigned this Aug 7, 2023
zanninso
zanninso requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now the second readme is better but you have to fix the thing mentioned in the first readme then we will see which is the better version to use.

subjects/java/Nexus/README1.md Outdated Show resolved Hide resolved
subjects/java/Nexus/README1.md Outdated Show resolved Hide resolved
subjects/java/Nexus/README1.md Outdated Show resolved Hide resolved
subjects/java/Nexus/README1.md Outdated Show resolved Hide resolved
subjects/java/Nexus/README2.md Outdated Show resolved Hide resolved
subjects/java/Nexus/README2.md Outdated Show resolved Hide resolved
subjects/java/Nexus/README2.md Outdated Show resolved Hide resolved
zanninso
zanninso approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i left two comment fix it and merge

zanninso
zanninso approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@zanninso zanninso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanninso zanninso merged commit 50798a1 into master Sep 19, 2023
2 checks passed
@zanninso zanninso deleted the CON-1774-MARKDOWN-Nexus-Java-Project branch September 19, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanninso zanninso zanninso approved these changes

Assignees

@akhossanX akhossanX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhossanX @zanninso