CON-1928-improve-stock-market-subject #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nprimo
commented
Aug 8, 2023
nprimo
commented
- update the number of stock to be monitored and update frequency to better deal with the API call limits
- update number of stock to be monitored and update frequency to better deal with the API call limits
akhossanX
reviewed
Aug 10, 2023
subjects/mobile-dev/stock-market/resources/mock-stock-data-server/README.md
Outdated
Show resolved
Hide resolved
akhossanX
reviewed
Aug 10, 2023
subjects/mobile-dev/stock-market/resources/mock-stock-data-server/Makefile
Outdated
Show resolved
Hide resolved
akhossanX
reviewed
Aug 10, 2023
subjects/mobile-dev/stock-market/resources/mock-stock-data-server/app.py
Outdated
Show resolved
Hide resolved
akhossanX
reviewed
Aug 10, 2023
subjects/mobile-dev/stock-market/resources/mock-stock-data-server/utils.py
Outdated
Show resolved
Hide resolved
akhossanX
reviewed
Aug 10, 2023
subjects/mobile-dev/stock-market/resources/mock-stock-data-server/app.py
Show resolved
Hide resolved
akhossanX
reviewed
Aug 10, 2023
- change port to avoid conflicts with defaults on macos - update .gitignore to exclude expanded stock data - remove repeated if statement in utils.py - remove comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.