Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2042: atm-management fix the questions #2195

Merged
merged 2 commits into from
Sep 18, 2023
Merged

CON-2042: atm-management fix the questions #2195

merged 2 commits into from
Sep 18, 2023

Conversation

MSilva95
Copy link
Member

the questions needed some more explaining because of the option to use relational dbs

@MSilva95 MSilva95 linked an issue Sep 15, 2023 that may be closed by this pull request
atm-management-system subject #2175
Closed
@MSilva95 MSilva95 self-assigned this Sep 15, 2023
@MSilva95 MSilva95 requested review from nprimo and removed request for nprimo September 15, 2023 16:18
@mikysett mikysett self-requested a review September 18, 2023 10:06
mikysett
mikysett approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@mikysett mikysett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just one little typo.

Feel free to fix it, resolve the conversation and merge, I think no further review is needed on my side ;)

subjects/atm-management-system/audit/README.md Outdated Show resolved Hide resolved
@MSilva95 MSilva95 mentioned this pull request Sep 18, 2023
Closed
mikysett
mikysett approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@mikysett mikysett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MSilva95 MSilva95 merged commit 1b56da3 into master Sep 18, 2023
2 checks passed
@MSilva95 MSilva95 deleted the CON-2042-atm-management-fix-questions branch September 18, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikysett mikysett mikysett approved these changes

Assignees

@MSilva95 MSilva95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

atm-management-system subject
2 participants
@MSilva95 @mikysett