Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-2309: graphql improve language #2317

Merged
merged 2 commits into from
Nov 27, 2023
Merged

Conversation

MSilva95
Copy link
Member

there was no question to verify the usage of the svg as asked in the readme...
"This graphs must be done using [SVG]"
Took the chance to improve the language as well

@MSilva95 MSilva95 linked an issue Nov 27, 2023 that may be closed by this pull request
@MSilva95 MSilva95 self-assigned this Nov 27, 2023
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(nothing major + not linked to the changes made) In the README of the subject there is a \ at line 62 that is not required and actually inserts a new line in a weird way.

Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! :)

@MSilva95 MSilva95 merged commit 256bac9 into master Nov 27, 2023
2 checks passed
@MSilva95 MSilva95 deleted the CON-2309-tackle-2312-graphql branch November 27, 2023 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql subject : is external libraries allowed (for svg graphs)
2 participants