CON-2774 Update DOM Dockerfile #2641
Conversation
HarryVasanth
changed the title
There was a problem hiding this comment.
@lotoussa I left just some general comments. Could you please elaborate a bit on why you want to make these changes?
Besides that, this image is also used for part of our content for the JS part of the curriculum besides the Discovery Piscine (just for your information) :)
| @@ -1,6 +1,24 @@ | |||
| FROM buildkite/puppeteer:7.1.0 | |||
| FROM alpine:latest | |||
There was a problem hiding this comment.
better to specify the version to avoid unexpected version conflicts in the future
| RUN apk add --no-cache \ | ||
| chromium \ | ||
| nss \ | ||
| freetype \ | ||
| harfbuzz \ | ||
| ca-certificates \ | ||
| ttf-freefont \ | ||
| nodejs \ | ||
| yarn |
There was a problem hiding this comment.
Is there any specific reason for installing all these individually instead of using, for example, the docker image suggested in the official documentation?
|
|
||
| WORKDIR /app | ||
| COPY dom . |
There was a problem hiding this comment.
Keep in mind that his Dockerfile needs to work for our GitHub Actions :)
The command used to build the image is here
|
|
@lotoussa should we close this PR? :) |
|
@nprimo hello yes i believe it's not relevant |
CON-2774
Why?
Update the DOM Dockerfile. This version was used in previous Discovery piscine in order to properly work, and is now push to the public official repository as it will be used for the IA Discovery Piscine.
Solution Overview
The Dockerfile content come from a copy paste of another docker file of the public repository, it has been tested already on previous Discovery Piscine and seem to work but still need a double check.