Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-2948 Markdown DPXAI: Quest00-Ex01 #2645

Merged
merged 5 commits into from
Jul 23, 2024
Merged

CON-2948 Markdown DPXAI: Quest00-Ex01 #2645

merged 5 commits into from
Jul 23, 2024

Conversation

Oumaimafisaoui
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui commented Jul 16, 2024 •
edited by jira bot
Loading

@Oumaimafisaoui
feat/test(DPxAI): Added the subject and modified naming for the test …
3f88f7e 
…of Quest00/Ex01 and modified the .gitignore file
@Oumaimafisaoui Oumaimafisaoui changed the title feat/test(DPxAI): Added the subject and modified naming for the test … feat/test(DPxAI:Quest00/Ex01): Added the subject and modified naming for the test … Jul 16, 2024
nprimo
nprimo suggested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments inline

dom/call-it_test.js Show resolved Hide resolved
subjects/DPxAI/call_it/README.md Outdated Show resolved Hide resolved
@Oumaimafisaoui Oumaimafisaoui removed the request for review from nprimo July 16, 2024 20:45
@HarryVasanth HarryVasanth changed the title feat/test(DPxAI:Quest00/Ex01): Added the subject and modified naming for the test … CON-2948 Markdown DPXAI: Quest00-Ex01 Jul 16, 2024
@HarryVasanth HarryVasanth added the 🗂️ docs Documentation label Jul 16, 2024
nprimo
nprimo suggested changes Jul 18, 2024
View reviewed changes
subjects/DPxAI/call_it/README.md Outdated Show resolved Hide resolved
nprimo
nprimo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nprimo
nprimo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@nprimo nprimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nprimo nprimo merged commit f9949d3 into master Jul 23, 2024
3 checks passed
@nprimo nprimo deleted the CON-2948-Markdown-DPXAI-Quest00-Ex01 branch July 23, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nprimo nprimo nprimo approved these changes

Assignees

@Oumaimafisaoui Oumaimafisaoui

Labels
🗂️ docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Oumaimafisaoui @nprimo @HarryVasanth