Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CON-3183 Fixing instructions in AI.GO/only-if #2739

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

Oumaimafisaoui
Copy link
Contributor

Why?

The instructions were not clarifying enough what will be tested.This goes with tests following the old exercise : special promo.

Solution Overview

Added clear instructions that are compatible with the tests.

@Oumaimafisaoui Oumaimafisaoui added 🗂️ docs Documentation 📕 AI Artificial Intelligence labels Sep 26, 2024
@Oumaimafisaoui Oumaimafisaoui self-assigned this Sep 26, 2024
@Oumaimafisaoui Oumaimafisaoui changed the title Fix instructions in AI.GO/only-if Fixing instructions in AI.GO/only-if Sep 26, 2024
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HarryVasanth HarryVasanth changed the title Fixing instructions in AI.GO/only-if CON-3183 Fixing instructions in AI.GO/only-if Sep 27, 2024
Copy link
Member

@Frenchris Frenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the grammar and a bit of the formatting more towards the end of the subject.
If we keep the variable ticket and ask the student to declare it then it should be removed from the tests where it is pre declared. I ll see to it with @MSilva95

@Oumaimafisaoui Oumaimafisaoui force-pushed the CON-3183-Fixing-issue-in-only-if-subject branch 2 times, most recently from 9cbb3e7 to 7961cc2 Compare October 3, 2024 09:46
@Oumaimafisaoui Oumaimafisaoui force-pushed the CON-3183-Fixing-issue-in-only-if-subject branch from 7961cc2 to 84a49a2 Compare October 6, 2024 20:16
@Oumaimafisaoui Oumaimafisaoui merged commit 0d8f2f2 into master Oct 7, 2024
3 checks passed
@Oumaimafisaoui Oumaimafisaoui deleted the CON-3183-Fixing-issue-in-only-if-subject branch October 7, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕 AI Artificial Intelligence 🗂️ docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants