Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CON-3184 Fixing instructions in AI.GO/first-wink #2740

Merged
merged 3 commits into from
Oct 2, 2024
Merged

CON-3184 Fixing instructions in AI.GO/first-wink #2740

merged 3 commits into from
Oct 2, 2024

Conversation

Oumaimafisaoui
Copy link
Contributor

@Oumaimafisaoui Oumaimafisaoui commented Sep 26, 2024 •
edited
Loading

Why?

The instructions were not stating clearly what is expected to be submitted.

Solution Overview

  • The 'button' element is selected by ID.
  • The name of the variables are more expressive.
  • The comments in the code example are more compatible with the new solution. Kindly find it in the following PR: New Solution
  • The prompts are compatible with the instructions.

@Oumaimafisaoui Oumaimafisaoui added the 🗂️ docs Documentation label Sep 26, 2024
@Oumaimafisaoui Oumaimafisaoui self-assigned this Sep 26, 2024
@HarryVasanth HarryVasanth changed the title Fixing instructions in AI.GO/first-wink CON-3184 Fixing instructions in AI.GO/first-wink Sep 27, 2024
@HarryVasanth HarryVasanth added the 📕 AI Artificial Intelligence label Sep 27, 2024
MSilva95
MSilva95 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Frenchris
Frenchris approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@Frenchris Frenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a little commit for a typo in another subject and some minor clarifications. It's good for me.

@Oumaimafisaoui Oumaimafisaoui force-pushed the CON-3184-Fix-issue-in-first-wink-subject branch from acf43b3 to c6efb1f Compare October 2, 2024 12:16
@Oumaimafisaoui Oumaimafisaoui merged commit 3b79b28 into master Oct 2, 2024
3 checks passed
@Oumaimafisaoui Oumaimafisaoui deleted the CON-3184-Fix-issue-in-first-wink-subject branch October 2, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenchris Frenchris Frenchris approved these changes

@MSilva95 MSilva95 MSilva95 approved these changes

Assignees

@Oumaimafisaoui Oumaimafisaoui

Labels
📕 AI Artificial Intelligence 🗂️ docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Oumaimafisaoui @Frenchris @MSilva95 @HarryVasanth