Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-#### Fix of ai.go js tests to match updated subjects #2750

Merged
merged 3 commits into from
Oct 3, 2024

Conversation

Frenchris
Copy link
Member

Why?
After the miscine was tested as a student, two tests had some inconsistencies with updated subjects.

Solution Overview
Fixes of inconsistencies to match two updated subjects.

@Frenchris Frenchris self-assigned this Oct 1, 2024
@Frenchris Frenchris added the 📕 AI Artificial Intelligence label Oct 1, 2024
Copy link
Contributor

@lotoussa lotoussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you

Copy link
Member

@MSilva95 MSilva95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Left a small comment on listed, but it's just a personal opinion

@Oumaimafisaoui Oumaimafisaoui removed their request for review October 2, 2024 12:15
@Oumaimafisaoui Oumaimafisaoui force-pushed the DEV-####-Review-of-AI.GO-js-tests branch from 6782562 to 8c4315f Compare October 2, 2024 13:19
@lotoussa
Copy link
Contributor

lotoussa commented Oct 2, 2024

@Oumaimafisaoui lgtm after check with runner

components variable must be an Array: PASS components first element must be motor: PASS components second element sensor: PASS components third element battery: PASS components fourth element camera: PASS components we must not have a fifth element: PASS firstPart is the value of the first element: PASS firstPart is the value of the first element even if we change the list: PASS lastPart is the value of the last element: PASS lastPart is the value of the last element even if we change the list: PASS comboParts is an array of lastPart and firstPart: PASS comboParts is an array of lastPart and firstPart even if we change the list: PASS replaceComponents third element is 'enhanced': PASS 1st and 2nd elements of swapComponents are swapped pif,paf,pom: PASS

Test with the falsy value 0: PASS Test with the falsy value NaN: PASS Test with the falsy value undefined: PASS Test with the falsy value null: PASS Test with the falsy value '': PASS Test with the falsy value false: PASS Test with the truthy value 'Sure': PASS Test with the truthy value []: PASS Test with the truthy value {}: PASS Test with the truthy value true: PASS Test with the truthy value -0.1: PASS Test with a user that can have the promotion: PASS Test with a user that is too old: PASS Test with a user that is too young: PASS Test with a user that doesn't have an active membership: PASS Test with a user that can have the promotion but is just at the limit: PASS Test with a customer that has enough cash: PASS Test with a customer that has a voucher: PASS Test with a customer that has a voucher and cash: PASS Test with a customer that can not afford the ticket: PASS

@Oumaimafisaoui Oumaimafisaoui force-pushed the DEV-####-Review-of-AI.GO-js-tests branch from 8c4315f to 5ca7ed6 Compare October 3, 2024 09:50
Copy link
Member Author

@Frenchris Frenchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me as I am the one proposing most of those changes.

And it s good if it was tried thru the runner as per last comment of Louis. Seems to be tested correctly from my point of view.

@Frenchris Frenchris added the 📦 build Build test images label Oct 3, 2024
@Frenchris Frenchris merged commit e62a3cd into master Oct 3, 2024
3 checks passed
@Frenchris Frenchris deleted the DEV-####-Review-of-AI.GO-js-tests branch October 3, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕 AI Artificial Intelligence 📦 build Build test images
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants