Make Rc lists clonable without cloning any of its elements. #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes reference-counted lists clonable without cloning any of its elements.
Reference-counted lists are used to store the contents of bound variables in jaq.
As they are part of the filter execution context, they are very frequently cloned.
So far, cloning such a list would always clone the head of list, in addition to cloning an
Rc
-pointer to the tail of the list.After this change, cloning only clones an
Rc
-pointer to the list.The performance implication of this change is quite favourable:
empty
bf-fib
reverse
sort
group-by
min-max
add
kv
kv-update
kv-entries
ex-implode
reduce
try-catch
tree-flatten
tree-update
tree-paths
to-fromjson
ack