Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global save file not saved if you close program via ALT-F4 #118

Closed
drojf opened this issue Jan 2, 2024 · 1 comment
Closed

Global save file not saved if you close program via ALT-F4 #118

drojf opened this issue Jan 2, 2024 · 1 comment

Comments

@drojf
Copy link
Contributor

drojf commented Jan 2, 2024

A user reported issues with their volume slider not matching the game state

While this did fix the issue: #117

I asked them to restart their game, and they said the volume reset to 100%

It turned out the user had been closing the game via ALT-F4, which causes the game to not save the global.dat file, containing the volume (and other things)


To fix this

  • Save global.dat periodically (although it would be hard to know exactly when because there are so many files there)
  • OR Hook ALT-F4 and do save when exiting via this method . But this won't prevent issues if the game crashes, for example.

May also want to check whether saving the global.dat is done in such a way it is not corrupted if the process is interrupted half-way.

@drojf
Copy link
Contributor Author

drojf commented Jan 2, 2024

Actually I tested this and it does save on ALT-F4, the report was me misreading the user's comment

@drojf drojf closed this as completed Jan 2, 2024
@drojf drojf added open-inconclusive Open discussions, concerns without concrete resolutions and removed open-inconclusive Open discussions, concerns without concrete resolutions labels Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant