OG mode artset switching issues thread

[drojf]

I decided to make just one issue listing all issues with the OG artset mode, so I can see them all in one place. Here are the current issues I need to chase up:

TODO

• Add og sprites/backgrounds to hou plus (perhaps try the method below?)
• Consider porting background/sprites directly from OG scripts?

From a user on discord.

recently I replayed Onikakushi unmodded on steam and for example keichi eating mochi happens not in the kitchen, but in his living room which is huge. You get a completely different feel and mood for the situation. You feel how big the keichi mansion is and how unsettling it is to be there alone. You also afterwards in the GOU anime recognise that same living room from the og.
locations that I didnt understand why are there in GOU appeared in unmodded steam version
And were beautiful to look at
having 3 different angles of keichi's room feels even more as if you're in his shoes. Its incredible
Basically significantly more immersive if there are more og backgrounds

• Complete hou sprite update, which should also fix the eye cut-in issue: OG sprites lower quality than previous chapters / Use Hou+ Sprites higurashi-rei#14

Known Issues

• [OG Backgrounds] matu_t1 and matu_t2 use PS3 version in OG Mode matsuribayashi#46
• Wrong eye cut-in images in OG mode and other eye issues minagoroshi#38
• OG Sprites / Backgrounds Known Issues higurashi-rei#10
• PS3 background displayed even in OG mode watanagashi#114
• When the "negative/color inversion" effect is applied, the black letterboxing to make it 4:3 turns white
• Tips/Preview thumbnails use the new console art instead of the old/ryukishi art (I think they're baked into the sharedassets0.assets file)
• Offset choice buttons, see New DLL Testing Thread #65 (comment)
  • A fix for this has been created, but not yet merged into mod branch, see 31996c0
• Transparent/stretched sprite issue [Spoiler] [Experimental DLL + OG Mode ] [low prirority] (this issue was only ever reported once)
• Unnecessary file accesses when OG mode is enabled
• Switching from console to original when zoom effect is active may cause issues - note: this might be fixed on the latest DLL, since a bug on Matsuribayashi was fixed on the latest DLL which happens when you change to OG mode.

Chapter specific issues:

• Tsumihoroboshi issues Fixed
• Meakashi issues Fixed
• Wrong title image for Minagoroshi/Matsuribayashi
• Stretched mangagamer logo in some chapters

General Notes / Oddities with OG mode

• sprites and backgrounds may not always match the OG game / voice only patch. You probably want the voice-only patch if you want it to match exactly
• To avoid having to remake all the text assets, any text assets (images which are just text on black background) which are in 16:9 will remain 16:9, even in 4:3 mode

[drojf]

Matsuribayashi) Looks like switching from console presentation to original presentation is a bad idea while this zoom effect is active.

[drojf]

Sprite positions being different as compared to the umodded game has been fixed by 74c247b, "Revert sprite position in 4:3 mode"

Click here for details on the issue

• Sometimes our game script has modified sprite standing positions compared to the unmodded game, to better fit widescreen (the x position is changed from 160/-160 to 240/-240). When you play in OG mode, this causes sprites to appear different/more cut-off as compared to the base game.

Here is an example from the start of chapter 2, just after the card game scene:

Original (french) Ch2

Unmodded Mangagamer Ch2

Our mod with Original/Ryukishi mode enabled

[drojf]

I was monitoring the game file accesses, and noticed that when OG background are enabled, all sprites would attempt to be found in the OGBackgrounds folder. This is due to some hardcoded logic I added here, which will check all paths in the OGBackgrounds folder first, when OGBackgrounds are enabled

higurashi-assembly/Assets.Scripts.Core.AssetManagement/AssetManager.cs

Lines 121 to 128 in 20babea

	if (backgroundSetIndex == 2)
	{
	string filePath = Path.Combine(Path.Combine(assetPath, "OGBackgrounds"), name);
	if (File.Exists(filePath))
	{
	return filePath;
	}
	}

This could be fixed by not looking in the OGBackgrounds folder if the path contains sprite or portrait.

public string PathToAssetWithName(string name, PathCascadeList artset)

I don't think this currently causes any performance issues though.

[drojf]

Issue: Wrong title screen image for minagoroshi or matsuribayashi when using OG mode

For minagoroshi, I need a replacement for the image ji1_menu (picture of a tori gate at a shrine)

I haven't checked the filename for matsuribayashi yet (close up of the moon)

[drojf]

Issue: Stretched Mangagamer logo

In the OG image pack, I included a stretch Mangagamer logo for some reason. The base mod already includes a proper 16:9 version of this image, so I should just.,..delete the image in the OG image pack and use the one that comes with the mod (for all chapters).

[drojf]

We apply filters to sprites to match the console backgrounds, for example if the background is at sunset (orange tinted), we apply the sunset filter to sprites so they match the background.

However, the OG backgrounds are not necessarily tinted the same way for the sunset images. The OG backgrounds should have night images, but I'm not sure if this is always the case.

This can create a slight conflict (depending on the background image), where the sprite will be tinted, but the OG background will be 'normal'

Note that I actually did generate OG backgrounds for the flashback etc. filters, since they are in a separate folder. But since the sunset/night variants are just in the same folder as all the other images, I didn't process those OG images to match the Console game.

In my testing, this is not very noticeable on the backgrounds I saw, because the sunset tint is not very strong.

Because of this, I'm not sure I want to fix this issue unless there are some really bad examples of it where it looks really bad