Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check game behavior when it cannot compile game scripts / behavior with long game paths #95

Open
drojf opened this issue Nov 7, 2022 · 0 comments

Comments

@drojf
Copy link
Contributor

drojf commented Nov 7, 2022

NOTE: This report was from an older version of the mod from April this year.


A user reported an issue on Onikakushi where their game wouldn't allow them to continue at a certain point (the game wouldn't crash, but no new text would be displayed on the screen).

Failed to compile script zonik_tips_01_vm00_n01!

System.IO.DirectoryNotFoundException: Could not find a part of the path

The issue was that the path of the game was too long, and the total path to the zonik_tips_01_vm00_n01.mg script was 262 chars, over the 260 char limit. So the game couldn't ever compile that script because it couldn't write to the too-long path.

This was mainly due to extra subdirs (presumably from extracting zip files) - the path ended with GOG_-_Higurashi_When_They_Cry_Hou\GOG - Higurashi When They Cry Hou\Higurashi When They Cry Hou - Ch.1 Onikakushi\HigurashiEp01_Data\StreamingAssets\CompiledUpdateScripts\zonik_009_02_vm00_n01.mg, but any user could just create a deep path even without this happening.

On this older version of the mod, even though a script failed to compile, they were still able to play the game.

I have to double check whether this is still the case on our newer version of the mod, because we really shouldn't allow this (and show an error message if it happens)


I was also worried about users installing the mod to a path which is too long, but I don't think it should be normally possible to mod the game when the game path is too long, because the installer will fail to be able to create some files.

Moving the modded game to a too-long path also shouldn't be possible (Windows should prevent you from doing this).

Perhaps in the installer, we should give a heads up if the path you chose is way too deep (if we don't already).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant