Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various volume issues #117

Draft
wants to merge 2 commits into
base: mod
Choose a base branch
from
Draft

Fix various volume issues #117

wants to merge 2 commits into from

Conversation

drojf
Copy link
Contributor

@drojf drojf commented Dec 17, 2023

There are two audio issues which I noticed

  • Sometimes, the audio volume will glitch to maximum for one frame (as if you had your BGM volume slider set to max, for example). I haven't confirmed that my change fixes this issue, however, since I couldn't reproduce it easily.
  • The first time you launch the game, the actual volume level, and the volume slides on the config menu were out of sync. When you rebooted the game, it would fix. I've tested my changes to fix this (which should prevent any possible desync of the volume sliders/volume flag variables to the actual volume), but am not sure if these fixes break anything else in the engine.

 - audioSource.volume is set in Update, so possibly audio can start playing, then have one frame before volume is set correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant