Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Thread #1

Open
6 of 19 tasks
drojf opened this issue Nov 10, 2023 · 5 comments
Open
6 of 19 tasks

Patch Thread #1

drojf opened this issue Nov 10, 2023 · 5 comments

Comments

@drojf
Copy link
Contributor

drojf commented Nov 10, 2023

TODO

DLL updates (drojf)

I've produced an early version of the mod DLL, which can be downloaded here:

  • ModSetLayerFilter function briefly draws unfiltered first, thne they switch to filtered color (for sprites)
  • Backlog plays voice from previous entry instead of clicked entry (should be easy fix)
  • Switching textbox type while in game sometimes doesn't work correctly (I guess this is lower pirority if you can reload to fixe it, and it works from then onwards)
  • Fix movie playback issues (file missing handling, video playback in low resolution)
  • Check whether special text window with hatchet is displayed with new DLL (window.png)
  • Push DLL changes once they're tested to be OK
  • Check whether backlog "click on line to replay voice" feature still works
  • Character names don't appear in NVL/OG mode, even when specified in nameformat? all previous chapters work like this, there is an if statement on every nametag line which disables it if not in ADV mode

DLL Download: https://github.com/07th-mod/hou-plus/releases/ - just take the HigurashiEp10_Data/Managed/Assembly-CSharp.dll file and nothing else.

Build System (drojf)

OG Mode / Mangagamer CG and Sprites

  • Add Mangagamer Sprites option
  • Fix MG CGs "There's a handful of MG CGs that could be edited to fit our resolution. Some don't have alternatives and are in OG style."
  • Add OG sprites/backgrounds
  • Add OG sprites/backgrounds to installer and wiki manual install page

After initial release updates

BGM/SE Options (drojf)

Update photoshop archives

Update archive on this page: https://07th-mod.com/wiki/developer/graphics/psd-files-templates/

  • Archive pixelguin's photoshop files

Manual Install

  • Add Manual Install instructions to Wiki

Save Changes

@orian34
Copy link
Contributor

orian34 commented Nov 12, 2023

The sprites is usually something I do while going through the script.
For the rest, it's mostly whatever you need to be done in the script, and me making sure it matches to the console version as well as various scripting improvements.

@Auu-Auu
Copy link

Auu-Auu commented Nov 18, 2023

Sharedassets and new UI

Music and Sound Effects from Hou (Overg)

  • Upload and send drive to Drojf
  • Use if helpful? (likely not)

Sprite Flaws

Reference (Chronological Order)

drojf added a commit to 07th-mod/higurashi-assembly that referenced this issue Nov 21, 2023
@drojf
Copy link
Contributor Author

drojf commented Jan 11, 2024

It was found that some of the voices are not used in the script:

WARNING: the following voice files are never used in the script:
ps3/meha/keiichi9240a
ps3/s24/02/nren_0210
ps3/s25/12/nhan_1165
ps3/s26/53/tmio_0960
ps3/s26/53/tmio_0970

Orian went through them, with the following comments

The keiichi line doesn't have a place, maybe it's an alt that didn't get used or something? Same for Hanyuu.
Rena line is a double take with 215.
I restored the nipah lines, the script censored them(not really) :BlemiCry:
Somehow the kak line was just missed. Rika's many "so?" just got confused. Same for mion's "and because of the rain!".
Finally, the 960 970 don't seem to have a place either, might be cut script.

@drojf
Copy link
Contributor Author

drojf commented Feb 3, 2024

Completed Items

Console Porting (orian)

  • Update init.txt by copying from Rei, but without some BGM/SE options etc. if not available
  • Add console graphics, sprites etc.
  • Update script to match console versions

Lip Sync

  • Generate lipsync sprites (enumag?)
  • Lipsync is now working afaik

DLL Updates

  • Check updated DLL (DLL updated again 2024-01-01) - NOTE: apparently there were no changes, even though the DLL was rebuilt? hopefully I didn't miss anything.
  • Check updated DLL (DLL updated 2023-11-12) and merge into Higurashi-Assembly repository
  • Finish merging mod changes into new DLL
  • Fix any bugs found during initial mod testing
    • Fix ADV mode suddenly shifting to the left when certain effects happen (happens near the start of outbreak after a screen-shake event)
    • Fix font size not restoring in ADV mode when game is started (loading a save seems to work though)
      • This turned out to be some lines in flow.txt which deliberately change the font size etc. in the unmodded game. I'm going to comment them out for now. See 779425c
    • Fix ADV mode text jumping downwards the first time you click to advance text?
    • Fix/test movie playback
    • Fix textbox backgrounds - did file names change? or did vanilla ADV break our textbox background stuff?
    • Fix japanese mode

Add voices to scripts (enumag, if available)

  • Convert switch scripts to a format parseable by robomi
  • Run robomi on the Mangagamer Hou+ scripts (Partially completed)
  • Merge voiced lines together to match console scripts (drojf)
    • so robomi can match properly
    • so can play without clicking multiple times for each voice file

Voice Archive

  • Has been created by olga, but not publicly available. Upload to 07th-mod server?
  • Need to fix voice pack: Mehagashi voices need to be put into their respective character number folder. (to follow PlayVoice path convention)

Installer Assets (Pixelguin)

Installer (drojf)

@drojf
Copy link
Contributor Author

drojf commented Feb 5, 2024

I noticed a 'reboot to title' just now after I loaded a save and played for about 5 seconds, due to a thrown exception. Not sure if it was me working on the mod that caused it, or an actual bug. I was messing with the window mode settings too at the time.

I'm not that concerned if the crash happens just after loading as you can just reload that same save.

It's complaining that the nameformat was null, so rather simple to do a null check, but I would want to know the actual cause of the crash

ArgumentNullException: Value cannot be null.
Parameter name: format
  at System.String.FormatHelper (System.IFormatProvider provider, System.String format, System.ParamsArray args) [0x00003] in <44afb4564e9347cf99a1865351ea8f4a>:0 
  at System.String.Format (System.String format, System.Object arg0) [0x00008] in <44afb4564e9347cf99a1865351ea8f4a>:0 
  at Assets.Scripts.Core.History.TextHistory.RegisterLine (System.String english, System.String japanese, System.String nameen, System.String namejp) [0x000cd] in <35c96c258b784624a08fdf16b35eb4da>:0 
  at Assets.Scripts.Core.Buriko.BurikoScriptFile.OperationOutputLine () [0x0007f] in <35c96c258b784624a08fdf16b35eb4da>:0 
  at Assets.Scripts.Core.Buriko.BurikoScriptFile.ExecuteOperation (Assets.Scripts.Core.Buriko.BurikoOperations op) [0x0038b] in <35c96c258b784624a08fdf16b35eb4da>:0 
  at Assets.Scripts.Core.Buriko.BurikoScriptFile.CommandOperation () [0x0001d] in <35c96c258b784624a08fdf16b35eb4da>:0 
  at Assets.Scripts.Core.Buriko.BurikoScriptFile.Next () [0x0006d] in <35c96c258b784624a08fdf16b35eb4da>:0 
  at Assets.Scripts.Core.Buriko.BurikoScriptSystem.Advance () [0x00000] in <35c96c258b784624a08fdf16b35eb4da>:0 
  at Assets.Scripts.Core.GameSystem.Update () [0x00234] in <35c96c258b784624a08fdf16b35eb4da>:0 
 
(Filename: <44afb4564e9347cf99a1865351ea8f4a> Line: 0)

Full Log:
Untitled-2.zip (lots of junk in the log because I was logging something else)


Probably fixed in 07th-mod/higurashi-assembly@c4dcce3

drojf added a commit to 07th-mod/higurashi-assembly that referenced this issue Feb 5, 2024
 - I think this bug exists in the vanilla game, but perhaps it doesn't cause any issues
 - Previously, ReadOptionalString() would return null instead of the default value
 - In our code, this could lead to 'restart to title' due to a thrown exception, see 07th-mod/hou-plus#1 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants