Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck sprite issues #37

Open
drojf opened this issue Aug 24, 2021 · 5 comments
Open

Stuck sprite issues #37

drojf opened this issue Aug 24, 2021 · 5 comments

Comments

@drojf
Copy link
Contributor

drojf commented Aug 24, 2021

Just recording another stuck sprite issue.

This happened on July 24th this year, so they should have the version of the mod with the fixes we've made at the end of 2020.

EDIT: 2022-08-05 just got another report of this exact image

Honeyview_SPOILER_unknown

I think the screenshot is from one of these two scripts (but the bug could have happened earlier)

NULL, "\"Heh heh!", Line_WaitForInput);

NULL, "\"Heh heh!", Line_WaitForInput);

Main issue: 07th-mod/higurashi-assembly#45

edit: this was already reported by me here in 2020: 07th-mod/higurashi-assembly#45 (comment)

@drojf
Copy link
Contributor Author

drojf commented Aug 24, 2021

There do appear to be some sprites drawn / faded from layer 0 on those scripts:

ModDrawCharacter(0, 12, "sprite/ha3a_au_", "2", 0, 0, 0, FALSE, 0, 0, 0, 0, 0, 0, 0, 9, 200, TRUE );

FadeBustshotWithFiltering( 0, "maskright" , 1, FALSE, 0, 0, 300, TRUE );

ModDrawCharacterWithFiltering(0, 10, "sprite/iri2_def2_", "2", "maskright", 1, 0, 0, FALSE, 0, 0, 0, 0, 0, 9, 300, TRUE );

FadeBustshotWithFiltering( 0, "maskleft" , 1, FALSE, 0, 0, 300, TRUE );

@drojf
Copy link
Contributor Author

drojf commented Sep 13, 2021

Here's another report for matsuribayashi from Discord:

The other day I was playing matsuribayashi with the mod (chapter 7) and at a given point sprites fucked up

Basically some sprites were blocked in the background and overlapped to new ones, like in this pic (the center tomitake is the glitched one)

The problem went away when I restarted the game, so it wasn't anything serious, but maybe my feedback may help for some troubleshooting in case it's needed

It was a bit funny because at some time there was Oiishi talking behind the glitched tomitake :RikaUnsureNipahd:

20210908211228_1

@drojf
Copy link
Contributor Author

drojf commented Nov 11, 2021

We had another report of the first image, even on the new DLL (the one in #37 (comment))

Below is an edited transcript of the conversation we had


C: Hello, I saw on the wiki that I should upload my save if I encounter a sprite layering issue, what file do I need to upload?
...discussion about how to get save files omitted...
C: This is Ch8 Matsuribayashi, the save is the default slot 0(?), reloading the game did not appear to have the layer reload but I have a screenshot of the thumbnail

steam_autocloud.zip

D: ah... if reloading the save doesn't show the issue it probably isn't that useful unfortuantely
D: I can see it in the thumbnail though
C: It happened a line or two of dialogue before this if that helps but I'm sure if the issue was that consistent it would be more easy to solve

D: when did you install the mod?
C: Two days ago I believe
Using the installer

C: I noticed that lip sync broke before the layering issue happened
D: I'm pretty sure it's this, which we already have recorded
oh really?
C: Yeah that looks exactly the same
D: so you were just playing normally, then the lip sync stopped playing?
C: Yeah Hanyuu's sprite stopped animating before the next sprite layered over
Only for that sprite
Mion's lip sync continued as normal
D: btw, when you play, do you click through voice lines?
like click through to the next line before the voice has finished
C: I believe this happened once before in another chapter and I failed to record it but iirc the lip sync seemed to break before the sprite issue as well (however this is just an estimation)
I do yes
D: did the sprite go away by itself? or were you forced to reload to get rid of it?
C: I didn't continue to see if it would fade, I just saved immediately
I could try loading a quicksave and see if I can get it to happen again but I'd be surprised if it was that easy to reproduce

@drojf
Copy link
Contributor Author

drojf commented Nov 17, 2021

Another stuck sprite issue - NOTE: the user was playing on Console mode, but switched to OG mode to show that mion is the one stuck on the screen (as in, mion was unaffected by the sprite switching, so she was the one who was stuck).

mion disappeared some time after by herself

edit: "In the white flashes between scenes, Mion was there too like in the screenshot I sent"

Honeyview_SPOILER_unknown (2)

@drojf
Copy link
Contributor Author

drojf commented Aug 5, 2022

I noticed that in Rei, the internal DrawBustShotWithFiltering function was changed slightly (the whole function was wrapped in a delegate)

I'm wondering if changing the previous chapters to draw filtered sprites with the same method would change anything.

Also wondering if all the stuck sprite issues always occur with a ModDrawCharacterWithFiltering call (even if it's not the same character)

EDIT: looks like rei has the same stucksprite issue (although not sure if it is due to lipsync or not) the issue happened without lipsync enabled, since it was hiru PC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant