Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lipsync not working due to wrong ModPlayVoiceLS character number #36

Open
drojf opened this issue Jan 7, 2023 · 0 comments
Open

Lipsync not working due to wrong ModPlayVoiceLS character number #36

drojf opened this issue Jan 7, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@drojf
Copy link
Contributor

drojf commented Jan 7, 2023

It was reported that in a scene involving Tomita and Okamura, lipsycn was not working for those characters (but some other characters like Rena worked fine).

I investigated it, and it looks like the script just has the wrong character number for ModPlayVoiceLS, so even though the voice plays, it doesn't animate the lipsync.

In the below example, Tomita has character number 24, but ModPlayVoiceLS uses character number 0. Since they don't match, no lipsync occurs.

ModDrawCharacter(2, 24, "sprite/tomita1_ikari_", "0", -160, 0, 0, FALSE, 0, 0, 0, 0, 0, 0, 0, 10, 0, FALSE );
DrawSceneWithMask( "background/gk3", "maskright", 1, 0, 300 );
if (GetGlobalFlag(GADVMode)) { OutputLine("<color=#a17d6b>富田</color>", NULL, "<color=#a17d6b>Tomita</color>", NULL, Line_ContinueAfterTyping); }
ModPlayVoiceLS(4, 0, "ps2/00/182400009", 540, TRUE);
OutputLine(NULL, "「ま、前原さん!",
NULL, "\"Maebara-san!", Line_WaitForInput);
ModPlayVoiceLS(4, 0, "ps2/00/182400010", 540, TRUE);
OutputLine(NULL, " これは明白な児童虐待です!!",
NULL, " This is a blatant case of child abuse!!", Line_WaitForInput);
ModPlayVoiceLS(4, 0, "ps2/00/182400011", 540, TRUE);
OutputLine(NULL, " 例え北条さんが暴行を受けていなかったからと言って、虐待を受けていないという根拠にはなりえません!」",
NULL, " Just because she doesn't have any injuries doesn't prove that she's not getting abused!\"", GetGlobalFlag(GLinemodeSp));

I'm not sure how much this occurs through our scripts, but it should be something relatively easy to scan for obvious cases (like reference a character who never appears in a file), but slightly harder to scan for cases where a character used to be in the scene but is no longer visible.

Also, the DLL does not emit any warning if this happens, which we probably should do.

@drojf drojf added the bug Something isn't working label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant