Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shion and Keiichi switching places in dialouge #39

Open
Raedrim opened this issue Jan 13, 2024 · 2 comments
Open

Shion and Keiichi switching places in dialouge #39

Raedrim opened this issue Jan 13, 2024 · 2 comments

Comments

@Raedrim
Copy link

Raedrim commented Jan 13, 2024

I noticed around chapter 5 that some scenes are voice acted by a certain character but the speaker name on the interface would be swapped (Shion in place of Keiichi and vice versa)
screenshot
In chapter 6, the line starts with "So taking into consideration ..." is spoken by Keiichi-s va and labeled correctly.
But the other dialogue, which I show with a green line in the screenshot, "What?! What the hell were..." is spoken by Shion-s va, and in context, it makes perfect sense that her character does the talking, it's just mislabeled.
If the issue is not duplicated, I will continue to log it if I notice it in later chapters.

@drojf
Copy link
Contributor

drojf commented Jan 13, 2024

I had a quick look and you're correct, the nametag at the top is for Keiichi, but it should be shion.

if (GetGlobalFlag(GADVMode)) { OutputLine("<color=#956f6e>圭一</color>", NULL, "<color=#956f6e>Keiichi</color>", NULL, Line_ContinueAfterTyping); }
ModPlayVoiceLS(4, 1, "org/shion6087", 256, TRUE);
OutputLine(NULL, "「はぁッ?!",
NULL, "\"What?!", Line_WaitForInput);
ModPlayVoiceLS(4, 1, "org/shion6088", 256, TRUE);
OutputLine(NULL, " 去年のあんたたちは何をやってたんですか!!",
NULL, " What the hell were you guys doing last year?!", Line_WaitForInput);
ModPlayVoiceLS(4, 1, "org/shion6089", 256, TRUE);
OutputLine(NULL, " 叔父叔母夫婦で共に虐めてたんです!!",
NULL, " She was being abused by both her aunt and uncle!!", Line_WaitForInput);
ModPlayVoiceLS(4, 1, "org/shion6090", 256, TRUE);
OutputLine(NULL, " まさか叔母だけが虐めてたって認識じゃないですよね?!」",
NULL, " Please don't tell us that you were only aware about the abuse from her aunt!!\"", Line_Normal);
ClearMessage();

How often do you think this happened? If it's only a couple times then we can just fix it manually, but if it's all over the place, it may be better to scan for them automatically.

@Raedrim
Copy link
Author

Raedrim commented Jan 13, 2024

Not sure about the exact number, but even in chapter 5 I would say it only happened two or three times max in the entire scene that both characters were present.
Will keep the thread updated, just reading through the game for the first time so might take a while :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants