Improve end of install notification and messages

- Disable alert() at end of installation - "Install Finished" is already displayed on page, so alert not needed - Because alert was removed, the browser won't display a notification at the end of the install. - Make error alert non-blocking - if error alert is blocking, the page won't say "error" until you click OK - Add proper umineko install failure message
07th-mod · Jul 14, 2019 · 70c8081 · 70c8081
1 parent 134bca0
commit 70c8081
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/httpGUI/favicon-notify.png b/httpGUI/favicon-notify.png
diff --git a/httpGUI/installer.html b/httpGUI/installer.html
@@ -2,7 +2,7 @@
 <!doctype html>
 <html lang="en">
     <head>
-		<link rel="icon" type="image/png" href="favicon.png" />
+		<link id="favicon" rel="icon" type="image/png" href="favicon.png" />
         <meta charset="utf-8">
         <title>07th-Mod Installer</title>
         <meta name="viewport" content="width=device-width, initial-scale=1.0">
@@ -89,7 +89,7 @@ <h4>IMPORTANT INFO BEFORE YOU PLAY</h4>
 				<h1 style="color: red;">The install failed :(</h1>
 				<p> Please check the last few mesages in the terminal output for more information. </p>
 				<div v-if="selectedMod === null ? false : selectedMod.includes('Umineko')">
-					<p>Common Umineko install failure reasons go here.</p>
+					<p>Please make sure you have a legal copy of the game, and that you have enough free disk space to install the patch.</p>
 				</div>
 				<div v-else>
 					<p>A common reason for the Higurashi installation to fail is that you have an <b>old version of the game</b>.</p>

diff --git a/httpGUI/python-patcher-lib.js b/httpGUI/python-patcher-lib.js
@@ -41,7 +41,7 @@ function statusUpdate() {
             app.installFinished = true;
             app.subTaskDescription = 'Install Finished!';
             app.subTaskPercentage = 100;
-            alert("Install Finished! Before closing the installer, launch the game to make sure it works correctly. Click the troubleshooting button for help if something goes wrong.");
+            document.getElementById('favicon').setAttribute('href', 'favicon-notify.png');
           }
         }
         if (status.overallTaskDescription !== undefined) {
@@ -74,10 +74,10 @@ function statusUpdate() {
           }
           // If status.msg is defined, status.error will also be defined
           if (status.error) {
-            alert(status.msg);
             app.installFailed = true;
             app.installFinished = true;
             window.clearInterval(statusUpdateTimerHandle);
+            setTimeout(() => { alert(status.msg); }, 100);
           }
         }
       });