Skip to content

Commit

Permalink
fix: Remove redundant never default from readFragment with explic…
Browse files Browse the repository at this point in the history
…it generic (#371)
  • Loading branch information
kitten authored Aug 18, 2024
1 parent 1a2df0e commit 15da5c3
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 16 deletions.
5 changes: 5 additions & 0 deletions .changeset/hip-sheep-provide.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"gql.tada": patch
---

Remove redundant `never` default on `readFragment<Document>()` signature (explicit generic passed)
32 changes: 16 additions & 16 deletions src/api.ts
Original file line number Diff line number Diff line change
Expand Up @@ -533,55 +533,55 @@ function readFragment<
): T extends resultOrFragmentOf<Document> ? ResultOf<Document> : T;

// Reading arrays of fragments with required generic
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly resultOrFragmentOf<Document>[]
): readonly ResultOf<Document>[];
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly (resultOrFragmentOf<Document> | null)[]
): readonly (ResultOf<Document> | null)[];
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly (resultOrFragmentOf<Document> | undefined)[]
): readonly (ResultOf<Document> | undefined)[];
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly (resultOrFragmentOf<Document> | null | undefined)[]
): readonly (ResultOf<Document> | null | undefined)[];
// Reading arrays of fragments with required generic with optional `{}` type
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly (resultOrFragmentOf<Document> | {})[]
): readonly (ResultOf<Document> | {})[];
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly (resultOrFragmentOf<Document> | null | {})[]
): readonly (ResultOf<Document> | null | {})[];
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly (resultOrFragmentOf<Document> | undefined | {})[]
): readonly (ResultOf<Document> | undefined | {})[];
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: readonly (resultOrFragmentOf<Document> | null | undefined | {})[]
): readonly (ResultOf<Document> | null | undefined | {})[];
// Reading fragments with required generic
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document>
): ResultOf<Document>;
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document> | null
): ResultOf<Document> | null;
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document> | undefined
): ResultOf<Document> | undefined;
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document> | null | undefined
): ResultOf<Document> | null | undefined;
// Reading fragments with required generic with optional `{}` type
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document> | {}
): ResultOf<Document> | {};
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document> | null | {}
): ResultOf<Document> | null | {};
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document> | undefined | {}
): ResultOf<Document> | undefined | {};
function readFragment<const Document extends FragmentShape = never>(
function readFragment<const Document extends FragmentShape>(
fragment: resultOrFragmentOf<Document> | null | undefined | {}
): ResultOf<Document> | null | undefined | {};

Expand Down

0 comments on commit 15da5c3

Please sign in to comment.