fix(cli-utils): Fix undefined symbol crash and output bug in `turbo…

…` command (#205)
0no-co · Apr 15, 2024 · e5f09db · e5f09db
1 parent 47b6964
commit e5f09db
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/.changeset/light-files-travel.md b/.changeset/light-files-travel.md
@@ -0,0 +1,5 @@
+---
+"@gql.tada/cli-utils": patch
+---
+
+Fix crash in `generate turbo` command when `returnType.symbol` is undefined
diff --git a/packages/cli-utils/src/commands/turbo/runner.ts b/packages/cli-utils/src/commands/turbo/runner.ts
@@ -84,7 +84,8 @@ export async function* run(tty: TTY, opts: Options): AsyncIterable<ComposeInput>
       }
 
       cache = Object.assign(cache, signal.cache);
-      if ((warnings += signal.warnings.length)) {
+      warnings += signal.warnings.length;
+      if (signal.warnings.length) {
         let buffer = logger.warningFile(signal.filePath);
         for (const warning of signal.warnings) {
           buffer += logger.warningMessage(warning);

diff --git a/packages/cli-utils/src/commands/turbo/thread.ts b/packages/cli-utils/src/commands/turbo/thread.ts
@@ -43,7 +43,9 @@ async function* _runTurbo(params: TurboParams): AsyncIterableIterator<TurboSigna
     for (const call of calls) {
       const returnType = checker.getTypeAtLocation(call);
       const argumentType = checker.getTypeAtLocation(call.arguments[0]);
-      if (returnType.symbol.getEscapedName() !== 'TadaDocumentNode') {
+      // NOTE: `returnType.symbol` is incorrectly typed and is in fact
+      // optional and not always present
+      if (!returnType.symbol || returnType.symbol.getEscapedName() !== 'TadaDocumentNode') {
         const position = getFilePosition(sourceFile, call.getStart());
         warnings.push({
           message: