Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(cli-utils): Add fallbacks for version checks to doctor command #358

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

kitten
Copy link
Member

@kitten kitten commented Jul 31, 2024

See: #357

Summary

While it's correct that we'd want users to install gql.tada locally in packages, depending on where the command is run, the local package.json may not contain all dependencies. This lifts this limitation and basically makes sure of the basics:

  • typescript should be available via a direct import() since it's a direct dependency of the CLI (via peer)
  • @0no-co/graphqlsp should be available via a direct require() from the package since it's a direct dependency of the CLI (via peer)
  • gql.tada should be available via a require() from the working directory, since it must be present to start up the CLI

This should generally allow us to be a little more lenient in the doctor checks.

Set of changes

  • Add helpers/versions to doctor for version checking

@kitten kitten requested a review from JoviDeCroock July 31, 2024 10:15
Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: eebcc1d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten changed the title Fix/add fallback versions patch(cli-utils): Add fallbacks for version checks to doctor command Jul 31, 2024
@kitten kitten merged commit 4b5a90e into main Jul 31, 2024
2 checks passed
@kitten kitten deleted the fix/add-fallback-versions branch July 31, 2024 10:45
@github-actions github-actions bot mentioned this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants