fix: build tx packages similar to Bitcoin Core #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation build packages with a global view of the available transactions. This is different from how Bitcoin Core inserts packages into a block template. For smoother feerate distribution plots, the package building algorithm changed to only account for local packages (i.e. transactions next to each other in the block). This also simplifies the package building.
0xB10C
force-pushed
the
2023-11-refactor-package-building
branch
from
1d099fb
to
4c2eb95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation build packages with a global view of the available transactions. This is different from how Bitcoin Core inserts packages into a block template. For smoother feerate distribution plots, the package building algorithm changed to only account for local packages (i.e. transactions next to each other in the block). This also simplifies the package building function as a whole.
before:
after:
