Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #123

Merged
merged 7 commits into from
Nov 28, 2024
Merged

Fix failing tests #123

merged 7 commits into from
Nov 28, 2024

Conversation

rachit77
Copy link
Contributor

Tests were failing because of bad kurtosis config in workflow

@rachit77 rachit77 requested a review from a team as a code owner November 28, 2024 12:31
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a side note:
we are not generating any load to the CDK node, so empty batches are created?

Probably we should consider using this script to generate some load and make sure batches are in verified state: https://github.com/0xPolygon/kurtosis-cdk/blob/main/.github/scripts/monitor-verified-batches.sh. WDYT?

.github/workflows/regression-tests.yml Outdated Show resolved Hide resolved
.github/workflows/regression-tests.yml Outdated Show resolved Hide resolved
.github/workflows/regression-tests.yml Outdated Show resolved Hide resolved
@rachit77 rachit77 merged commit d97c040 into main Nov 28, 2024
9 checks passed
@rachit77 rachit77 deleted the fix/tests branch November 28, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants