Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zero zkEVM] - Revert encoding change back to RLP #1148

Closed
Nashtare opened this issue Sep 9, 2024 · 3 comments · May be fixed by #1360
Closed

[zero zkEVM] - Revert encoding change back to RLP #1148

Nashtare opened this issue Sep 9, 2024 · 3 comments · May be fixed by #1360
Assignees
@Stefan-Ethernal
Labels
zero zkEVM Ticket specific to Polygon Zero zkEVM
Milestone
v2.61.x (zero pro...

Comments

@Nashtare
Copy link

Nashtare commented Sep 9, 2024

Zero zkEVM already supports RLP encoding to support vanilla MPTs for Txn / Receipt tries without this being a real bottleneck, it'd be best to remain consistent and reuse the regular MPT format for these 2 tries as well for the type2.
@Nashtare Nashtare mentioned this issue Sep 9, 2024
Closed
3 tasks
@Nashtare Nashtare added the zero zkEVM Ticket specific to Polygon Zero zkEVM label Sep 9, 2024
@cffls
Copy link

cffls commented Oct 22, 2024 •
edited
Loading

@Nashtare is this regarding zero tracer or the trie roots in the block header?

The implementations of tx/receipt encoding are the same in both cdk-erigon and type1 erigon. If we are talking about zero tracer, do you mean to change the encoding in both places?

If we are talking about the trie roots of txns and receipts in the block header, I believe they are calculated the same way as type 1.

@Stefan-Ethernal Stefan-Ethernal mentioned this issue Oct 24, 2024
Open
@mandrigin mandrigin added this to the v2.61.x (zero prover) milestone Oct 30, 2024
@cffls
Copy link

cffls commented Nov 5, 2024 •
edited
Loading

As discussed with @Nashtare , the tx hash function in question was ComputeL2TxHash.
This function affects:

  1. L2 block info tree
  2. Datastream
  3. zkevm_* rpc

1 will be disabled in Normalcy HF, 2 is agnostic to zero prover, and 3 won't be used by zero prover. Therefore, this is a non-issue once #1374 is merged.

@Stefan-Ethernal
Copy link
Collaborator

It was addressed through #1374.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stefan-Ethernal Stefan-Ethernal

Labels
zero zkEVM Ticket specific to Polygon Zero zkEVM
Projects
None yet
Milestone
v2.61.x (zero prover)
Development

Successfully merging a pull request may close this issue.

Encode transactions to RLP format in zero tracer 0xPolygonHermez/cdk-erigon
4 participants
@mandrigin @Nashtare @cffls @Stefan-Ethernal