Skip to content
This repository has been archived by the owner on Sep 15, 2020. It is now read-only.

Illegal filename character while dumping frontpage service information #5

Open
maaaaz opened this issue May 29, 2014 · 0 comments
Open
Labels

Comments

@maaaaz
Copy link

maaaaz commented May 29, 2014

Hello dude,

First, I would like to thank you for your NTLM patch, that was really a needed one.

Second, I would like to report a bug : you are not filtering illegal filename chars when you dump frontage service information.
In the frontpage_service_listing function, line 382:

filename = "__service-list__.txt" + entry + ".html"
service_list = open(filename, 'a')

entry comes from the list on line 370 and contains bad chars such as ':' (colon).

Please filter any bad char in filename before attempting to write into them with this:

re.sub('[^\w\-_\. ]', '_', filename)

Best regards,
Thomas.

@0xdevalias 0xdevalias added the bug label May 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants