minor

0xsequence · Aug 30, 2023 · a24e6c3 · a24e6c3
1 parent b9455c7
commit a24e6c3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/ethmonitor/ethmonitor.go b/ethmonitor/ethmonitor.go
@@ -653,7 +653,6 @@ func (m *Monitor) fetchBlockByHash(ctx context.Context, hash common.Hash) (*type
 		maxNotFoundAttempts, notFoundAttempts := 2, 0 // waiting for node to sync
 		maxErrAttempts, errAttempts := 2, 0           // quick retry in case of short-term node connection failures
 
-		// var block *types.Block
 		var blockPayload []byte
 		var err error
 
@@ -684,7 +683,7 @@ func (m *Monitor) fetchBlockByHash(ctx context.Context, hash common.Hash) (*type
 					continue
 				}
 			}
-			if blockPayload != nil {
+			if len(blockPayload) > 0 {
 				return blockPayload, nil
 			}
 		}

diff --git a/ethrpc/ethrpc.go b/ethrpc/ethrpc.go
@@ -196,7 +196,7 @@ func (p *Provider) RawBlockByHash(ctx context.Context, hash common.Hash) ([]byte
 	if err != nil {
 		return nil, err
 	}
-	if result == nil || string(result) == "null" {
+	if len(result) == 0 || string(result) == "null" {
 		return nil, ethereum.NotFound
 	}
 	return result, nil
@@ -217,7 +217,7 @@ func (p *Provider) RawBlockByNumber(ctx context.Context, blockNum *big.Int) ([]b
 	if err != nil {
 		return nil, err
 	}
-	if result == nil || string(result) == "null" {
+	if len(result) == 0 || string(result) == "null" {
 		return nil, ethereum.NotFound
 	}
 	return result, nil