harden ethmonitor for block header streaming errors #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // We default to polling if streaming is not enabled | ||
| m.log.Info("ethmonitor: starting poll head listener") | ||
|
|
||
| retryStreamingTimer := time.NewTimer(m.options.StreamingRetryAfter) |
There was a problem hiding this comment.
defer retryStreamingTimer.Stop()
| goto reconnect | ||
| } | ||
|
|
||
| blockTimer := time.NewTimer(3 * m.options.ExpectedBlockInterval) |
There was a problem hiding this comment.
nit: defer blockTimer.Stop()
There was a problem hiding this comment.
Resource leak, agrh... defer will not help as it never goes out of function scope. I will get that fixed asap.
There was a problem hiding this comment.
Actually, it is good. The timer will close itself after it fires and will be garbage collected. So there is no need to close it. It will also not cause process to hang. There will be at most a couple of them.
// After waits for the duration to elapse and then sends the current time
// on the returned channel.
// It is equivalent to NewTimer(d).C.
// The underlying Timer is not recovered by the garbage collector
// until the timer fires. If efficiency is a concern, use NewTimer
// instead and call Timer.Stop if the timer is no longer needed.
func After(d Duration) <-chan Time {
return NewTimer(d).C
}There was a problem hiding this comment.
“a little temporary timer leak” is fine imho
it’d probably be better to close it, though, to be accurate
(a leaked timeout might cause an unnecessary OS interrupt)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change can be tested by setting up local nodegateway, pointing watch cmd at it and stoping/restarting node gateway service.