Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ethreceipts: check for nil in isBlockFinal #95

Merged
merged 4 commits into from
Jul 25, 2023
Merged

ethreceipts: check for nil in isBlockFinal #95

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b984e1
ethreceipts: check for nil in isBlockFinal
pkieltyka Jul 25, 2023
605b3f7
fix ethrpc test
pkieltyka Jul 25, 2023
463b84d
update
pkieltyka Jul 25, 2023
7fe2b5f
l.latestBlockNum() -> latestBlockNum
attente Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ethreceipts/ethreceipts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,9 @@ func (l *ReceiptsListener) getMaxWaitBlocks(maxWait *int) uint64 {
}

func (l *ReceiptsListener) isBlockFinal(blockNum *big.Int) bool {
if l == nil || l.latestBlockNum() == nil || blockNum == nil {
return false
}
diff := big.NewInt(0).Sub(l.latestBlockNum(), blockNum)
pkieltyka marked this conversation as resolved.
Show resolved Hide resolved
return diff.Cmp(big.NewInt(int64(l.options.NumBlocksToFinality))) >= 0
}
Expand Down
10 changes: 5 additions & 5 deletions ethrpc/ethrpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func TestERC20MintAndTransfer(t *testing.T) {
}

func TestBlockByNumber(t *testing.T) {
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon/test")
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon")
require.NoError(t, err)

{
Expand All @@ -101,7 +101,7 @@ func TestBlockByNumber(t *testing.T) {
}

// func TestBlockRange(t *testing.T) {
// p, err := ethrpc.NewProvider("https://dev-nodes.sequence.app/optimism/test")
// p, err := ethrpc.NewProvider("https://dev-nodes.sequence.app/optimism")
// require.NoError(t, err)

// {
Expand All @@ -112,7 +112,7 @@ func TestBlockByNumber(t *testing.T) {
// }

func ExampleBatchCall() {
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon/test")
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon")
if err != nil {
panic(err)
}
Expand Down Expand Up @@ -143,7 +143,7 @@ func ExampleBatchCall() {

func TestETHRPC(t *testing.T) {
t.Run("Single", func(t *testing.T) {
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon/test")
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon")
require.NoError(t, err)

chainID, err := p.ChainID(context.Background())
Expand All @@ -153,7 +153,7 @@ func TestETHRPC(t *testing.T) {
})

t.Run("Batch", func(t *testing.T) {
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon/test")
p, err := ethrpc.NewProvider("https://nodes.sequence.app/polygon")
require.NoError(t, err)

var (
Expand Down
Loading