Feature/sample UI collection details #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on for a basic scale tweening animation.
…o the back key on various platforms, but for now, we have a UI button). Added a very minimal login screen for testing this out.
…e (e.g. open/close methods) and made ConnectPage and LoginPage inherrit from it
…lls the open/close methods on the UIPages directly.
…ncluded in my previous commit and I had to rebuild it... *sigh*
…ing the ITween interface) to animate the various UI pages. The main UI panel now scrolls in from the bottom
…e such that they debug.log what they are supposed to do when clicked
…the UI by creating a scriptable object via 'Assets>Create>Sequence>Color Scheme', setting it as the color scheme in the ColorSchemeManager monobehaviour/gameobject, and clicking Apply in the inspector
…gned to handle the login request. Currently, mocking the login. Upon success or failed login, an ILogin will emit an appropriate event. SequenceUI is a subscriber to this event.
…imations (didn't have animations out)
…w, there is only email validation - I have both a real (with tests) and mocked implementation of IValidator
…ereum. Created assembly for SequenceExamples - referencing all the other Sequence assemblies (minus test assemblies) in the project. Finally, create a SequenceExamplesTests assembly for any tests related to the SequenceExamples and renamed our other test assembly from Tests to SequenceTests for clarity.
…tication) under SequenceSDK and moved the authentication-related logic out of SequenceExamples and into Authentication.
…made it stop being a UIPage. Instead, created a UIPanel which inherrits from UIPage - this is used to create the LoginPanel and will be used for the WalletPanel as well
…UI tests in one test so we don't have to setup and teardown the scene each time - makes test suite faster.
…oPage. Use NftElement to populate NftUIElement and update mock fetcher
…this class is designed to reuse the code needed for spawning TransactionDetailsBlocks. Reducing copy-pasta
…hTransactionDetailsBlock. Both NftInfoPage and TokenInfoPage are now InfoPages
…abstract classes to improve readability
…oring collection related info in the NftElement directory
…rify that the CollectionInfos were being mapped to NftElements appropriately by CollectionNftMapper
…ng arguments) to SequenceSampleUI for tests. This allows us to create tests that start on any panel - allowing us the flexibility to split up our tests further while keeping runtimes at a minimum
… that we can get more granual results from our test suite. This will also make the WalletPanel test suite more manageable as it scales and will remove the risk of approaching the max runtime for a given test.
…oughNftInfoPages by reducing what info it tests on the NftInfoPages when clicking on the NftWithInfoText's button. This reduced the runtime from around 3 minutes to around 1.5 minutes
BellringerQuinn
force-pushed
the
Feature/sampleUi_collectionDetails
branch
from
ddb00b1
to
9d33119
Compare
Merged
|
Merged in with #36 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#31, #32, and #33 are pre-requisites
Added CollectionInfoPage. This can be navigated to by clicking on any UI element relevant to the collection on the NftInfoPage. Eventually, you will also be able to navigate to this page using the search page.
CollectionInfoPage.mov