This repository has been archived by the owner on Aug 8, 2024. It is now read-only.
feat: add no-nested-ternary to eslint rules #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvermootenct
requested review from
eswarclynn and
raviteja83
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@rvermootenct is attempting to deploy a commit to the 100mslive Team on Vercel. A member of the Team first needs to authorize it. |
raviteja83
approved these changes
Sep 21, 2023
|
@rvermootenct Thanks for contributing 🙌 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
A developer girl shouldn't have to hurt her brain to understand the logic flow in the application. Adding in warnings that nested-ternaries are not acceptable is a step in that direction.
More context
The app is littered in deeply nested ternaries, which by their nature is super hard to reason about and read. Considering this is a sample app, a lot of people are going to be reading the code.
Work Done
Added 'no-nested-ternary': 'error' to the eslint rules. Ideally this would be an error, but would create a lot of code needing to be updated before this could go in.
Steps to test
Add a nested ternary. Eslint should give you a warning.
GIF tax