delete the MirrorSparseMatrix type #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
requested review from
sjackman,
sreenathkrishnan,
shamoni and
nmmsv10x
sreenathkrishnan
approved these changes
Feb 29, 2024
| u64, | ||
| Vec<(String, u32, u32, u32)>, | ||
| )>::new(); | ||
| let mut results = Vec::<(usize, LoadResult)>::new(); |
There was a problem hiding this comment.
Woah! You managed to track each of the tuple elements 🙏
macklin-10x
added a commit
to 10XGenomics/enclone
that referenced
this pull request
Mar 6, 2024
Removes everything that depended on the known-dead MirrorSparseMatrix type removed in 10XGenomics/enclone_ranger#384 Deletes enclone_visual and everything I could find relating to it. Sets tests to panic instead of existing the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deletes the known-dead
MirrorSparseMatrixtype, and then proceeds to delete absolutely everything else that had anything to do with it.