further bin format cleanups #386
Conversation
macklin-10x
requested review from
sjackman,
sreenathkrishnan,
shamoni and
nmmsv10x
| if ctl.gen_opt.h5 { | ||
| let gex_outs = &ctl.origin_info.gex_path; |
There was a problem hiding this comment.
Could there be any inter-dependency between these two? Maybe some validation on the enclone side that ctl.origin_info.gex_path is present and is of length ctl.origin_info.dataset_path.len() if ctl.gen_opt.h5 is true. Wondering if we can get index out of bounds for gex_outs[i]
There was a problem hiding this comment.
I deleted this because after my refactoring, there is no condition under which gen_opt.h5 is ever false. This was set by the argument NH5 which was only used to tell enclone to read the (now deleted) binary count matrix instead of the .h5 version.
There was a problem hiding this comment.
Looks like they are populated together:
enclone_ranger/enclone_args/src/proc_args3.rs
Lines 688 to 689 in 5eeae8b
There was a problem hiding this comment.
In this refactoring process I've been trying to be very careful to make sure that I've confirmed that a conditional is constrained to exactly one path before removing it.
Removes several additional dead files/fields. Deletes a test definitions file that was an exact duplicate also present in
enclone.