clean up json handling #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
requested review from
sjackman,
sreenathkrishnan,
shamoni and
nmmsv10x
macklin-10x
force-pushed
the
macklin/clean-up-json-handling
branch
from
d295057
to
dcf69f9
Compare
sreenathkrishnan
approved these changes
Mar 6, 2024
| gex_cells_specified, | ||
| vdj_cells, | ||
| mut fate, | ||
| } = parse_json_annotations_files(ctl, refdata, to_ref_index)?; |
There was a problem hiding this comment.
Nice! A lot cleaner
| } | ||
| let frac_reads_used = ann | ||
| .fraction_of_reads_for_this_barcode_provided_as_input_to_assembly | ||
| .map(|f| (f * 1_000_000.0).round() as u32); |
There was a problem hiding this comment.
Wonder what is happening here with the 1M.
|
Once the associated enclone PR passes CI I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all custom JSON parsing code with serde. Inverts control flows to return values instead of mutating collections provided by arguments.
Stacked on another feature branch, will rebase after underlying branch merges.