deny clippy::type_complexity #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
requested review from
sjackman,
sreenathkrishnan,
shamoni and
nmmsv10x
macklin-10x
force-pushed
the
macklin/fix-clippy-lint-errors
branch
from
c89e029
to
14c4eb7
Compare
macklin-10x
force-pushed
the
macklin/clippy-type-complexity
branch
from
61a07e5
to
f3b0634
Compare
macklin-10x
force-pushed
the
macklin/clippy-type-complexity
branch
from
f3b0634
to
522d56e
Compare
sreenathkrishnan
approved these changes
Mar 21, 2024
| have_gex: bool, | ||
| gex_info: &GexInfo, | ||
| rsi: &ColInfo, | ||
| sr: &mut Vec<(Vec<String>, Vec<Vec<String>>, Vec<Vec<u8>>, usize)>, |
There was a problem hiding this comment.
Good that we got rid of two unused fields here
There was a problem hiding this comment.
And gigantic ones at that!
Comment on lines
-83
to
-88
| let mut bads = 0; | ||
| let mut denom = 0; | ||
| for r in results { | ||
| bads += r.2; | ||
| denom += r.3; | ||
| } |
There was a problem hiding this comment.
Oh, duplicated computation. Good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the allow exception for
clippy::type_complexityand fixes all errors. I was mostly able to replace anonymous tuples with structs, but one section relied on some existing tuple-specific logic so I created a type alias and moved on.Stacked on another feature branch, will rebase once underlying branch merges.