deny clippy::needless_range_loop #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macklin-10x
requested review from
sjackman,
sreenathkrishnan,
shamoni and
nmmsv10x
macklin-10x
force-pushed
the
macklin/clippy-type-complexity
branch
from
61a07e5
to
f3b0634
Compare
macklin-10x
force-pushed
the
macklin/clippy-needless-range-loop
branch
2 times, most recently
from
b153a1b
to
7b68073
Compare
macklin-10x
force-pushed
the
macklin/clippy-type-complexity
branch
from
f3b0634
to
522d56e
Compare
macklin-10x
force-pushed
the
macklin/clippy-needless-range-loop
branch
from
7b68073
to
08919b6
Compare
macklin-10x
force-pushed
the
macklin/clippy-needless-range-loop
branch
from
08919b6
to
652db5c
Compare
sreenathkrishnan
approved these changes
Mar 28, 2024
Fix dma Fix hyperbase. Fix fasta_tools. Fix graph_simple. Fix tables. Fix build_supp_ref. Fix build ref exons. Fix build_vdj_ref
Co-authored-by: Sreenath Krishnan <sreenath.krishnan@10xgenomics.com>
macklin-10x
force-pushed
the
macklin/clippy-needless-range-loop
branch
from
21dfcfc
to
b4069bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the exception to the
clippy::needless_range_looplint and fix many violations.I've validated this changeset by running enclone and cellranger's CI against it. Note that this did catch several bugs introduced in the annotation code, which I subsequently fixed. The changes in that file should be reviewed particularly closely.