Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collapse annotation helper types #406

Merged
merged 10 commits into from
Apr 17, 2024

Conversation

macklin-10x
Copy link
Contributor

@macklin-10x macklin-10x commented Mar 21, 2024

Collapses the three intermediate annotation types into a single Alignment struct. This was carefully done in a series of systematic steps; this PR may be easier to review commit-by-commit rather than viewing the entire diff as a unit.

@macklin-10x macklin-10x changed the base branch from main to macklin/break-up-annotation March 22, 2024 06:20
@macklin-10x macklin-10x force-pushed the macklin/collapse-annotation-helper-types branch from dcae517 to f914112 Compare March 22, 2024 18:55
@macklin-10x macklin-10x force-pushed the macklin/collapse-annotation-helper-types branch from f914112 to 4b954d7 Compare March 29, 2024 04:39
@macklin-10x macklin-10x force-pushed the macklin/collapse-annotation-helper-types branch from 4b954d7 to 4073a55 Compare April 2, 2024 04:23
Base automatically changed from macklin/break-up-annotation to main April 17, 2024 17:35
@macklin-10x macklin-10x force-pushed the macklin/collapse-annotation-helper-types branch from 4073a55 to f2f2e12 Compare April 17, 2024 17:37
Copy link
Contributor

@sreenathkrishnan sreenathkrishnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@macklin-10x macklin-10x merged commit d8eeecc into main Apr 17, 2024
2 checks passed
@macklin-10x macklin-10x deleted the macklin/collapse-annotation-helper-types branch April 17, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants