Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version from composer and update changelog.md #242

Merged

Conversation

unfulvio-godaddy
Copy link
Member

@unfulvio-godaddy unfulvio-godaddy commented Jan 19, 2024

Summary

Removes package version from composer.json. This should make packagist point to the git tags. Also updated the changelog.md to include changes from 1.0.1.

Closes: #241

Contributor checklist

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly
  • I have added tests to cover changes introduced by this pull request
  • All new and existing tests pass

Testing

  • All tests pass in CI

Reviewer checklist

  • Code changes review
  • Documentation changes review
  • Unit tests pass
  • Static analysis passes

@unfulvio-godaddy unfulvio-godaddy self-assigned this Jan 19, 2024
@unfulvio-godaddy unfulvio-godaddy requested a review from a team January 19, 2024 04:21
@coveralls
Copy link

coveralls commented Jan 19, 2024

Coverage Status

coverage: 66.312% (-0.1%) from 66.445%
when pulling d421e6a on chore/remove-composer-version-and-update-changelog-md
into dbd6762 on trunk.

@unfulvio-godaddy
Copy link
Member Author

Ignore coveralls when approving - does not impact code

Copy link
Contributor

@rneudorf-godaddy rneudorf-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unfulvio-godaddy unfulvio-godaddy merged commit 48b7f22 into trunk Jan 22, 2024
9 of 10 checks passed
@unfulvio-godaddy unfulvio-godaddy deleted the chore/remove-composer-version-and-update-changelog-md branch January 22, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.0.1 is not available on Packagist
3 participants