Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak on Apple M2 Max #184

Open
Choodz opened this issue Mar 28, 2023 · 8 comments
Open

Memory Leak on Apple M2 Max #184

Choodz opened this issue Mar 28, 2023 · 8 comments

Comments

@Choodz
Copy link

Choodz commented Mar 28, 2023

Description
The memory use increases with time. At launch, memory use is approximately 2 GB. After four hours, this had exceeded 10 GB. This was confirmed by checking Activity Monitor periodically.

To Reproduce
Use RuneLite with 117 HD plugin activated for an extended period of time.

Expected behavior
Memory use should not significantly increase with time.

Screenshots
This screenshot of Activity Monitor was captured after ~4 hours of RuneLite w/ 117 HD runtime:

Screenshot 2023-03-27 at 4 38 46 PM

Environment (please complete the following information):

  • OS: macOS Ventura 13.2.1
  • RuneLite version: 2.6.3 (Apple Silicon)

Additional context
RuneLite itself has been ruled out as a culprit after running it in "Safe Mode" which de-activates 117HD by default.

@aHooder
Copy link
Member

aHooder commented Mar 28, 2023

Interesting. A few questions:

  1. Do you have any other plugin hub plugins installed?
  2. Are you launching RuneLite with the standard launcher & default launcher memory settings?
  3. Does this also happen with RuneLite's GPU plugin?

This could be a bug with Apple's OpenGL driver, but we'd have to dig into it further to say for sure.

@Choodz
Copy link
Author

Choodz commented Mar 28, 2023

Thanks for the response, @aHooder. To address your questions:

  1. The only other plugin hub plugins installed are Quest Helper, Left Click Dropper, and Ping Graph.
  2. I am launching with the default launcher and memory settings.
  3. This would need to be tested -- I will try running for an extended period with GPU as opposed to 117HD and compare the results. I will be sure to report back with what I find.

@Choodz
Copy link
Author

Choodz commented Mar 31, 2023

I have tested memory use with the GPU plugin. After extended use (about ~7 hours with the client open, although it auto-logged out and my Mac went to sleep for a short time - about four hours of continuous use at the end) memory use stands at 2.39 GB. Upon launch, memory use is about 950 MB.

So there is a memory leak phenomenon happening with the GPU plugin itself as well, albeit on a much less intensive scale than 117HD. Of course, 117HD is much more memory intensive, but I don't know if it scales compared to the GPU plugin.

As stated above, 117HD launches at ~2GB of memory, and rises to >10GB within four hours. The GPU plugin only doubled in the same time frame.

@aHooder
Copy link
Member

aHooder commented Mar 31, 2023

Ah, thanks for looking into it. I would hazard a guess at it being caused by Apple's OpenGL driver not cleaning up after itself, but it's hard to say without looking at the raw data (and even then it would be tricky). Do let us know if you find any particular setting causes it to get worse though.

@TheGreatestJannet
Copy link

Same issue on Linux. I have had it go up to 18.5GB of RAM used. With the plugin enabled the RAM usage slowly goes up. With it disabled it stays at 1GB.

@aHooder
Copy link
Member

aHooder commented Apr 17, 2023

Same issue on Linux. I have had it go up to 18.5GB of RAM used. With the plugin enabled the RAM usage slowly goes up. With it disabled it stays at 1GB.

I'm not able to reproduce this on Linux with proprietary Nvidia drivers. Which drivers and GPU are you using? And what time scale approximately?

@TheGreatestJannet
Copy link

I’m using Nvidia proprietary drivers (530.41.03) with a GTX 1060 6GB. After around 4 minutes it is already at 4GB and then slowly goes up from there. Yesterday I had been playing for probably one hour or so and it was at 18.5GB. The same time with the normal GPU plugin it was at 1.5GB of RAM.

@aHooder
Copy link
Member

aHooder commented Apr 17, 2023

Are you sure this isn't just the model cache filling up? On my system, the base game uses roughly 2GB, and the model cache adds on top of that once it's filled up. What's your cache size set to?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants