Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vanilla shading reversal on tiles breaks snow hue and brightness #223

Open
SirFancyBacon opened this issue Jul 7, 2023 · 5 comments
Open
Labels
enhancement New feature or request

Comments

@SirFancyBacon
Copy link
Contributor

SirFancyBacon commented Jul 7, 2023

Describe the bug
When blending is enabled white level appears to be capped at a certain brightness where tiles like snow meet something dark; baked in shadow or dark tile; causing a negative visual impact.
See screenshots

To Reproduce
Steps to reproduce the behavior:

  1. Go to Fishing Hamlet or ice caves within Goblin Village
  2. Click on Toggle ground blending and see the difference in snow colors

Expected behavior
A more accurate blending of colors

Screenshots
image
image

Environment (please complete the following information):

  • OS: Mint 21.1; nvidia driver 530.28
  • RuneLite version: 1.10.8-snapshot
  • 117HD Version: 1.2.9.4
@SirFancyBacon SirFancyBacon changed the title Brightness issue on snow Brightness issue with snow Jul 7, 2023
@SirFancyBacon
Copy link
Contributor Author

Setting the color of the snow with .setBrightness() may resolve this issue; Will require tuned material for each area i suspect.

A hacky but workable solution

@SirFancyBacon
Copy link
Contributor Author

Follow up: it did not work :(

@aHooder
Copy link
Member

aHooder commented Oct 16, 2023

We could do the same as we did for legacy grey colors potentially:
image

image

@SirFancyBacon
Copy link
Contributor Author

Would we then want to make the environments respect that setting then? I am sure we are going to want to go touch up a lot of snow areas won't we change this setting

@aHooder
Copy link
Member

aHooder commented Nov 23, 2023

Since snow is partly fixable by overriding lightness, I'll repurpose this issue for some kind of solution to issues surrounding vanilla shading reversal on tiles.

@aHooder aHooder changed the title Brightness issue with snow Vanilla shading reversal on tiles breaks snow hue and brightness Nov 23, 2023
@aHooder aHooder added the enhancement New feature or request label Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants