Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Add a setting to adjust or turn off shadows on grass? #415

Open
korvl38 opened this issue Apr 14, 2024 · 6 comments
Open

[Suggestion] Add a setting to adjust or turn off shadows on grass? #415

korvl38 opened this issue Apr 14, 2024 · 6 comments

Comments

@korvl38
Copy link

korvl38 commented Apr 14, 2024

Hi so in areas with long grass like piscatoris the shadows are very strong, with every blade of grass getting shadows its a bit too much contrast for my eyes. I know I could just turn it off but my preference is for HD.

Actually even when shadows are turned off, each grass is still rendered. At some angles it just looks like
a million dark spikes all over the floor. Could we please have a small setting to adjust this to our liking? Thanks

@korvl38 korvl38 changed the title [Suggestion] Add a setting to adjust or shadows on grass? [Suggestion] Add a setting to adjust or turn off shadows on grass? Apr 14, 2024
@Jin-Jiyunsun
Copy link
Contributor

Could you provide a screenshot of your problem? We already disable most grass from casting shadow.

@korvl38
Copy link
Author

korvl38 commented Apr 15, 2024

Could you provide a screenshot of your problem? We already disable most grass from casting shadow.

Yes of course. I have turned my shadows off, see the comparison. I think its the shadow on the grass itself, everything looks very "spikey" I hope that makes sense. Note that I am choosing the worst lighting angle to demonstrate the issue, but the grass is very strong compared to SD

I know probably most people don't care but it's very tiring on my eyes. You could have a few levels of detail between SD and the current grass.
2024-04-15_10-32-47
2024-04-15_10-32-35
RuneLite_0ntgK1QoLb

@Jin-Jiyunsun
Copy link
Contributor

I will take a look into a soultion for this but I cant make any guarantees

@Jin-Jiyunsun
Copy link
Contributor

I'll drop a WIP, thoughts?

image

@korvl38
Copy link
Author

korvl38 commented Apr 16, 2024

@Jin-Jiyunsun thanks for the quick WIP. It's looking much better already. Seems you have AA on when I did not but either way it looks more natural and less strong on each individual grass.

I prefer closer to low resolution for grass but everyone has different taste, what kind of options are you able to add for adjusting grass settings between SD or HD?

@Jin-Jiyunsun
Copy link
Contributor

Jin-Jiyunsun commented Apr 16, 2024

I'll be attempting to tune it so it just looks good on a single setting, not really within the scope to offer multiple options for things like this. Had a few people give feedback regarding this so I think its worth trying to solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants