Update eslint, stylelint packages (major)

.eslintrc.json

@@ -15,14 +15,16 @@
         "no-multi-spaces": ["off"],
         "no-return-assign": ["off"],
         "@typescript-eslint/indent": ["error", 4],
-        "@typescript-eslint/semi": ["error", "always"],
-        "@typescript-eslint/object-curly-spacing": ["error", "never"],
-        "@typescript-eslint/space-before-function-paren": ["error", "never"],
-        "@typescript-eslint/promise-function-async": ["off"],
         "@typescript-eslint/no-confusing-void-expression": ["error", {"ignoreArrowShorthand": true}],
         "@typescript-eslint/no-extraneous-class": ["off"],
+        "@typescript-eslint/no-invalid-void-type": ["off", {"allowAsThisParameter":  true}],
         "@typescript-eslint/no-unnecessary-boolean-literal-compare": ["off"],
+        "@typescript-eslint/object-curly-spacing": ["error", "never"],
+        "@typescript-eslint/promise-function-async": ["off"],
         "@typescript-eslint/restrict-template-expressions": ["off"],
+        "@typescript-eslint/semi": ["error", "always"],
+        "@typescript-eslint/space-before-function-paren": ["error", "never"],
+        "@typescript-eslint/unbound-method": ["off"],
         "@typescript-eslint/member-delimiter-style": [
             "error",
             {

assets/ts/controllers/browser_notification_controller.ts

@@ -1,4 +1,5 @@
 import {Controller} from '@hotwired/stimulus';
+import type MercureEvent from '../entity/MercureEvent';
 import BrowserNotification from '../lib/BrowserNotification';
 
 export default class extends Controller {
@@ -12,7 +13,7 @@ export default class extends Controller {
     }
 
     private handleNotification(event: Event): void {
-        const data = (event as CustomEvent).detail;
+        const data = (event as CustomEvent<MercureEvent>).detail;
         this.notification.publish(data.title, data.message, 'tag-' + String(data.eventId), data.url);
     }
 }

assets/ts/controllers/comment_thread_controller.ts

@@ -12,7 +12,7 @@ export default class extends Controller<HTMLElement> {
     private readonly declare idValue: number;
     private readonly declare urlValue: string;
 
-    public commentUpdated(event: CustomEvent): void {
+    public commentUpdated(event: CustomEvent<string>): void {
         Events.stop(event);
         if (parseInt(event.detail) !== this.idValue) {
             return;

assets/ts/controllers/review_notification_list_controller.ts

@@ -1,4 +1,5 @@
 import {Controller} from '@hotwired/stimulus';
+import type MercureEvent from '../entity/MercureEvent';
 
 export default class extends Controller {
     public static targets = ['template'];
@@ -23,7 +24,7 @@ export default class extends Controller {
     }
 
     private handleNotification(event: Event): void {
-        const data = (event as CustomEvent).detail;
+        const data = (event as CustomEvent<MercureEvent>).detail;
 
         // skip notifications from me
         if (data.userId === this.userIdValue) {
@@ -40,8 +41,10 @@ export default class extends Controller {
 
     private createItem(message: string): HTMLElement {
         const clone = this.templateTarget.content.cloneNode(true) as HTMLElement;
-
-        (clone.querySelector('[data-role=item]') as HTMLElement).innerHTML = message;
+        const item  = clone.querySelector<HTMLElement>('[data-role=item]');
+        if (item !== null) {
+            item.innerHTML = message;
+        }
         return clone;
     }
 }

assets/ts/controllers/server_event_controller.ts

@@ -1,12 +1,13 @@
 import {Controller} from '@hotwired/stimulus';
+import type MercureEvent from '../entity/MercureEvent';
 import DataSet from '../lib/DataSet';
 
 export default class extends Controller<HTMLElement> {
     public connect(): void {
         const publishUrl      = DataSet.string(this.element, 'url');
         const eventSource     = new EventSource(publishUrl, {withCredentials: true});
-        eventSource.onmessage = (event) => {
-            const data = JSON.parse(event.data);
+        eventSource.onmessage = (event: MessageEvent<string>) => {
+            const data = JSON.parse(event.data) as MercureEvent;
             document.dispatchEvent(new CustomEvent(data.topic, {detail: data}));
         };
 

assets/ts/controllers/textarea_paste_controller.ts

@@ -18,7 +18,11 @@ export default class extends Controller<HTMLTextAreaElement> {
             return;
         }
 
-        const item         = event.clipboardData.items[0] as DataTransferItem;
+        const item = event.clipboardData.items[0];
+        if (item === undefined) {
+            return;
+        }
+
         const allowedMimes = ['image/png', 'image/gif', 'image/jpg', 'image/jpeg'];
         if (item.kind !== 'file' || allowedMimes.includes(item.type) === false) {
             return;

assets/ts/entity/MercureEvent.d.ts

@@ -0,0 +1,9 @@
+export default interface MercureEvent {
+    eventId: 1;
+    eventName: string;
+    topic: string;
+    userId: number;
+    title: string;
+    message: string;
+    url: string;
+}

assets/ts/lib/Errors.ts

@@ -1,5 +1,5 @@
 export default class Errors {
-    public static catch(error: any): void {
+    public static catch(this: void, error: any): void {
         // handle Axios error response
         if (error.response?.data?.error !== undefined) {
             alert(error.response.data.error);

assets/ts/lib/Mentions.ts

@@ -75,6 +75,7 @@ export default class Mentions {
         const params = new URLSearchParams({search: searchQuery ?? '', preferredUserIds: this.preferredUserIds.join(',')});
         axios
             .get('/app/user/mentions?' + params.toString())
+            // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
             .then(response => callback(response.data))
             .catch(Function.empty);
     }

assets/ts/service/CommentService.ts

@@ -14,7 +14,7 @@ export default class CommentService {
     public getAddCommentForm(url: string, oldPath: string, newPath: string, line: number, offset: number, lineAfter: number, headSha: string, state: string): Promise<HTMLElement> {
         return this.client
             .get(url, {params: {oldPath, newPath, line, offset, lineAfter, state, headSha}})
-            .then(response => response.data)
+            .then(response => (response.data as string))
             .then(html => Elements.create(html));
     }
 
@@ -34,7 +34,7 @@ export default class CommentService {
 
         return this.client
             .get(url, params)
-            .then(response => response.data)
+            .then(response => (response.data as string))
             .then(html => Elements.create(html));
     }
 

assets/ts/service/ReviewFileTreeService.ts

@@ -7,7 +7,7 @@ export default class ReviewFileTreeService {
     public getReviewFileTree(url: string, filePath: string | null): Promise<HTMLElement> {
         return this.client
             .get(url, {params: {filePath}})
-            .then(response => response.data)
+            .then(response => (response.data as string))
             .then(html => Elements.create(html));
     }
 }