update to version 3.4 throw ex :[Right-hand side of 'instanceof' is not an object]

[liva0126]

No description provided.

[liva0126]

This issue was fixed when I retreated to version 3.3.

[IDisposable]

Can you give me a repro on JSFiddle? I can't really debug from here.

[pschmiedelenbw]

Same error here, unfortunately I also cannot give you a repro. The call is something like

domtoimage.toPng(someElement, { bgColor: '#fff', height, width }).then(dataUrl => ...)

It seems the problem is in isShadowRoot() which when called with a document element calls getWindow() which tries to access the ownerDocument, however that is not set for document elements.

[IDisposable]

Pushing v3.4.2 to see if that fixes it... reverting part of a PR I merged.

[IDisposable]

Please verify or deny if v3.4.2 fixes this @pschmiedelenbw and @liva0126

[pschmiedelenbw]

That seems to fix the problem, thanks!

[cWenyu]

Hi @IDisposable , it seems breaks the slotted element, can you please double check release 3.4.2 with #178

[IDisposable]

Fixed in v3.4.3

[ktdd]

v3.4.3 is broken here with this error, 3.4.2 works. No ShadowDom in use, just a regular element.

[cWenyu]

I have no issues to use 3.4.3 with regular elements (no shadow dom), see the example: https://jsfiddle.net/CWenyu/rh4Ljqa5/5/

[cannot-hero]

I use 3.4.3, il still has this probem, so I retreated to version 3.3

[codesculpture]

@IDisposable
The library is broken, in this commit (specifically this line)

Object.hasOwn(value, 'getRootNode') which is not producing same output as 'getRootNode' in value

I am not sure the reason behind this but it is producing different output.
Kindly look at this , since we were depending on "disableEmbedFont" which is introduced in the same commit

Edit: I am not blocked by this issue, since 3.4.2 consists of disableEmbefFonts with revert of this Object.hasOwnProperty change. So am using 3.4.2 but still this needs to be fixed.

[codesculpture]

I use 3.4.3, il still has this probem, so I retreated to version 3.3

3.4.2 consist of revert of this issue, so its safe to use 3.4.2 in case you want disableEmbedFonts options.
@cannot-hero

[IDisposable]

How about v3.4.4 just released @codesculpture @cannot-hero @ktdd

[cannot-hero]

@IDisposable i just tried v3.4.4, still have this problem

[IDisposable]

I can't reproduce this anywhere, can you contribute a test to the .spec.js file?

[codesculpture]

Can we reopen this (this issue is not listed on my home page, where it seems only opened issues would pop up there, i need to manually come to the repo find this issue to comment)
@IDisposable

[codesculpture]

Duplicated this issue (since this is closed) here

[codesculpture]

This been addressed here #189