Package release 3.4.0 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As they fix bugs, my spec creeps.
Need to escape the emitted SVG in the debug output so we can just save as HTML and see how things looked different.
This will (optionally) reduce the size of the SVG and speed things up when no fonts need to be copied. Thanks to @davidburns573 and @YujiaCheng1996 Fixes #158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for ShadowSlotElement nodes with no assignedNodes to fall back to childNodes. Also fixed some more node.js compatibility (fixes #148 thanks @cWenyu).
Added option to not copy over the web fonts when generating an SVG to allow smaller/faster conversions (fixes #158 thanks @davidburns573 and @YujiaCheng1996).
Updated spec images to match current Chrome output.
Added code to unit-test so emitted debug string when there's a SVG output it is properly escaped.
Bumped dev dependencies for mocha 10.7.3 and eslint 9.9.0.