Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL regex rules, solving most font icon URL replacement issues #188

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix URL regex rules, solving most font icon URL replacement issues #188

merged 1 commit into from
Sep 12, 2024

Conversation

SeanZhang-eaton
Copy link

Before:

"https://fonts.gstatic.com/s/xx/vxx/xx.woff2".replace(/([.*+?^${}()|[]\/\\])/g, '\\$1')
'https://fonts.gstatic.com/s/xx/vxx/xx.woff2'

Didn't work
image

After:


"https://fonts.gstatic.com/s/xx/vxx/xx.woff2".replace(/([.*+?^${}()|[\]\/\\])/g, '\\$1')
'https:\\/\\/fonts\\.gstatic\\.com\\/s\\/xx\\/vxx\\/xx\\.woff2'

image

@SeanZhang-eaton
Copy link
Author

Can fix the following issues #15 #149 etc

@IDisposable IDisposable changed the title fix: fix url regex rules, solve most font icon url replacement issue Fix URL regex rules, solving most font icon URL replacement issues Sep 12, 2024
IDisposable
IDisposable approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@IDisposable IDisposable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks

@IDisposable IDisposable merged commit ad2bb59 into 1904labs:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IDisposable IDisposable IDisposable approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SeanZhang-eaton @IDisposable